Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

[Darshit Shah]

Hi Dagobert,

Thanks for running the tests and sharing that log. The unit-tests check specific 
functions for correctness. The test failing is the one that tests the 
hsts_store_entry() method in hsts.c. On a preliminary read, it seems like its 
trying to test something else, but we instead caught this issue. Tim / Ander 
should have a better idea. However, one thing we know is that this is a solaris 
specific issue since we don't see it on Linux. 

> Hi Tim,
>
> Am 17.11.2015 um 14:52 schrieb Tim Ruehsen <address@hidden>:
> > I just pushed the change.
>
> Excellent, the build now runs cleanly.
>
> > > Now only one test is failing:
> > > > FAIL: unit-tests
> > >
> > > How does think unit-test-thing work? I can’t find a log or some debug
> > > output.
> >
> > For every test you will have .log file in tests/ resp. testenv/.
> >
> > Have a look into tests/unit-tests.log. You'll see what function/test fails.
> > Post the output of the failing test here.
>
> I added that to the buildbot-logs to be catched. However, I don’t see an error 
> there:
>
> > [DEBUG] Testing...
> >
> > RUNNING TEST test_find_key_value...
> > PASSED
> >
> > RUNNING TEST test_find_key_values...
> > PASSED
> >
> > RUNNING TEST test_has_key...
> > PASSED
> >
> > RUNNING TEST test_parse_content_disposition...
> > PASSED
> >
> > RUNNING TEST test_parse_range_header...
> > PASSED
> >
> > RUNNING TEST test_subdir_p...
> > PASSED
> >
> > RUNNING TEST test_dir_matches_p...
> > PASSED
> >
> > RUNNING TEST test_commands_sorted...
> > PASSED
> >
> > RUNNING TEST test_cmd_spec_restrict_file_names...
> > PASSED
> >
> > RUNNING TEST test_path_simplify...
> > PASSED
> >
> > RUNNING TEST test_append_uri_pathel...
> > PASSED
> >
> > RUNNING TEST test_are_urls_equal...
> > PASSED
> >
> > RUNNING TEST test_is_robots_txt_url...
> > PASSED
> >
> > RUNNING TEST test_hsts_new_entry...
> > PASSED
> >
> > RUNNING TEST test_hsts_url_rewrite_superdomain...
> > A new entry should've been created
> > Tests run: 15
> > FAIL unit-tests (exit status: 1)
>
> So which test is failing? test_hsts_url_rewrite_superdomain ?
> There is no *hsts* in tests/
>
>
> Best regards
>
>  — Dago
>
> --
> "You don't become great by trying to be great, you become great by wanting to 
> do something,
> and then doing it so hard that you become great in the process." - xkcd #896



--
Thanking You,
Darshit Shah

signature.asc
Description: PGP signature