bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)


From: Tim Ruehsen
Subject: Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)
Date: Thu, 19 Nov 2015 12:25:54 +0100
User-agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; )

Thanks - good catch, Ander !

I pushed the patch.

Tim

On Thursday 19 November 2015 10:41:28 Ander Juaristi wrote:
> Hi Tim,
> 
> On 11/18/2015 11:09 AM, Tim Ruehsen wrote:
> > Hi Dagobert, hi Ander,
> > 
> > I could reproduce and fix the problem on a 32bit Debian wheezy VM.
> > 
> > @Dagobert Please check if the attached patch works on Solaris as well
> > @Ander Please review that I did not get anything wrong
> 
> I moved the calls to xfree (kh->host) a few lines up because I couldn't pass
> the unit tests after applying your patch (64-bit Linux Mint). The reason
> was simply that kh->host had garbage, and thus free() complained.
> 
> And also:
> 
>      PASS: Test--post-file.px
>      *** Error in `../src/wget': free(): invalid pointer: 0x0000000000d2c5f0
> *** PASS: Test-proxied-https-auth.px
>      *** Error in `../src/wget': free(): invalid pointer: 0x00000000021cc5f0
> ***
> 
> @Dagobert please check that it still passes all the tests in Solaris 32-bit.
> For some reason I couldn't compile it on a 32-bit Debian, and had no time
> to look into it further.
> > Tim
> 
> Regards,
> - AJ



reply via email to

[Prev in Thread] Current Thread [Next in Thread]