Re: [Bug-wget] unit-tests are failing on Intel 32bit architecture

[Tim Ruehsen]

Hi Tomas,

Ander is right, it was a 32bit issue or let's say a chain of issues.

Fixed here:

commit 99aa7b4f5e13a30e04d4410e98bbb81780e74f09
Author: Tim Rühsen <address@hidden>
Date:   Wed Nov 18 10:58:56 2015 +0100

    Fix HSTS memory issue + test code issue
    
    * src/hsts.c (hsts_find_entry): Fix freeing memory
      (hsts_remove_entry): Remove freeing host member
      (hsts_match): Free host member here
      (hsts_store_entry): Free host member here
      (test_url_rewrite): Fix 'created' value
      (test_hsts_read_database): Fix 'created' value
    
    Reported-by: Dagobert Michelsen <address@hidden>


Tim

On Friday 27 November 2015 14:31:25 Tomas Hozza wrote:
> Thanks for your response.
> 
> I went through the emails on the ML, but nothing seemed to be related.
> I'll look into git to see if I can find the fix.
> 
> Regards,
> Tomas
> 
> On 27.11.2015 14:17, Juaristi Álamos, Ander wrote:
> > Hi Thomas,
> > 
> > Thanks for your report. You're right. This issue raised almost as soon
> > as we released wget 1.17. It only affected 32-bit systems.
> > 
> > Hopefully, it's already fixed on Git.
> > 
> > Thanks.
> > - AJ
> > 
> > On Fri, 2015-11-27 at 13:26 +0100, Tomas Hozza wrote:
> > > Hi.
> > > 
> > > While updating the wget in Fedora, I found out that one of the
> > > unit-tests
> > > is failing on Intel 32bit architecture. When building on 64bit
> > > architecture, all unit-tests pass.
> > > 
> > > The one that is failing is:
> > > 
> > > RUNNING TEST test_hsts_url_rewrite_superdomain...
> > > A new entry should've been created
> > > 
> > > in src/hsts.c:689 is the failing line:
> > > 
> > > created = hsts_store_entry (s, SCHEME_HTTPS, "www.foo.com", 443,
> > > time(NULL) + 1234, true);
> > > 
> > > I didn't investigate further.
> > > 
> > > Regards,