[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Compilation Error when without-ssl is selected

From: Darshit Shah
Subject: Re: [Bug-wget] Compilation Error when without-ssl is selected
Date: Thu, 3 Dec 2015 17:21:52 +0100
User-agent: Mutt/1.5.24+27 (c799162691b2) (2015-08-30)

On 11/24, Tim Rühsen wrote:
Hi Ygal,

many thanks for the patch.

An interesting side effect of testing './configure --without-ssl' is that
there are at least three issues with the python test suite.

I made up patches for two of them (attached).

@Darshit Could you review 0001-Fix-python-test-suite-return-value.patch ? -
You are most familiar with the python test suite.

The third is that Test--rejected-log.py now reports error, but that seems to
be just coming out as a consequence of my test suite fix.


Hi Tim,

I took a look at the patches. There is a subtle bug somewhere in the Test Suite, but now I know how to reproduce it. I'll spend some time over next week to fix it.

However, I've attached another patch that can work well. We should not execute the tests if we know they will fail. I'm also going to look into SKIPping tests using this framework.

Getting back to topic, I'm pushing the HTTPS fix to Git right now. If there are no complains about the attached patch here, we can push it to Git later today / tomorrow.

On Tuesday 24 November 2015 11:26:43 Ygal Blum wrote:

When selecting without-ssl during configuration the compilation breaks.
Please find attached the patch with the fix.

Best Regards,
Ygal Blum

From b273c8aa85fdcd68c92b0908545769cac624218a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20R=C3=BChsen?= <address@hidden>
Date: Tue, 24 Nov 2015 16:30:04 +0100
Subject: [PATCH 1/2] Fix python test suite return value

* testenv/test/base_test.py: Return False on TestFailed exception
testenv/test/base_test.py | 2 ++
1 file changed, 2 insertions(+)

diff --git a/testenv/test/base_test.py b/testenv/test/base_test.py
index c5b82be..df4bec3 100644
--- a/testenv/test/base_test.py
+++ b/testenv/test/base_test.py
@@ -257,6 +257,8 @@ class BaseTest:
            self.tests_passed = False
            if exc_type is TestFailed:
                print_red('Error: %s.' % exc_val.error)
+                self.__test_cleanup()
+                return False
                print_red('Unhandled exception caught.')

From d23d9dcb7c28eea884b839e473250a2f7efff7e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20R=C3=BChsen?= <address@hidden>
Date: Tue, 24 Nov 2015 16:32:11 +0100
Subject: [PATCH 2/2] Add Test-hsts.py to SSL_TESTS

* testenv/Makefile.am: Add Test-hsts.py to SSL_TESTS
testenv/Makefile.am | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/testenv/Makefile.am b/testenv/Makefile.am
index c16a6c6..7fe24bd 100644
--- a/testenv/Makefile.am
+++ b/testenv/Makefile.am
@@ -37,7 +37,7 @@ AUTOMAKE_OPTIONS = parallel-tests
AM_TESTS_ENVIRONMENT = export WGETRC=/dev/null; MAKE_CHECK=True; export 
 export PYTHONPATH=$$PYTHONPATH:$(srcdir); export 

-SSL_TESTS = Test--https.py Test--https-crl.py
+SSL_TESTS = Test--https.py Test--https-crl.py Test-hsts.py
  TESTS = Test-auth-basic-fail.py                   \
    Test-auth-basic.py                              \
@@ -58,7 +58,6 @@ if HAVE_PYTHON3
    Test-Head.py                                    \
    Test--https.py                                  \
    Test--https-crl.py                              \
-    Test-hsts.py                                    \
    Test-O.py                                       \
    Test-Post.py                                    \
    Test-504.py                                     \

Thanking You,
Darshit Shah

Attachment: 0001-Do-not-run-unsupported-tests.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]