[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] Fixing progress bar assertions in multibyte locales

From: Darshit Shah
Subject: [Bug-wget] Fixing progress bar assertions in multibyte locales
Date: Tue, 8 Dec 2015 21:13:14 +0100
User-agent: Mutt/1.5.24+27 (c799162691b2) (2015-08-30)

Hi everyone,

As mentioned earlier, there was a bug in the progress bar implementation that caused the tests in multi-byte and multi-column locales to fail. I've rectified the issue by re-working each part of the progress bar to ensure that they are indeed using exactly the amount of space that has been allocated.

I also tried to clean up some of the code. I tested these commits on Travis and there seem to be no issues. All tests are passing with Russian, Turkish and C locales.

Please review the patch, and if good, I'll push it to master. Since it touches the most user-centric part of Wget, I'd like to see it as well reviewed and tested as possible.

Thanking You,
Darshit Shah

Attachment: 0001-Fix-progress-bar-assertion-with-multibyte-locales.patch
Description: Text Data

Attachment: 0002-Re-enable-test-on-multibyte-locale-in-Travis.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]