[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)
From: |
Tim Rühsen |
Subject: |
Re: [Bug-wget] flock is not available on solaris 10 (at least sparc) |
Date: |
Sat, 12 Dec 2015 19:15:17 +0100 |
User-agent: |
KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.14; x86_64; ; ) |
It is just the compiler/compiler flags that the buildbot uses.
CC and CFLAGS not set and the error is reproducible.
With CC=gcc and CFLAGS="-std=c89 -Wall -O2" the build runs fine.
I'll make some more tests to find the exact point. I guess Dagobert might
adjust some settings for the buildbot.
Tim
Am Samstag, 12. Dezember 2015, 18:52:57 schrieb Darshit Shah:
> Exactly! But I checked the gnulib changelog. Nothing major seems to
> have changed that causes such a fault.
> Most of the commits seem to be documentation related only.
>
> Also, like you said, the compiler message is not helpful at all. Need
> someone who is more experienced in such systems to take alook
>
> On 12 December 2015 at 18:49, Tim Rühsen <address@hidden> wrote:
> > Am Samstag, 12. Dezember 2015, 17:57:00 schrieb Darshit Shah:
> >> Didn't we fix this by using the Gnulib module?
> >> I thought all the tests were passing on Solaris after that. What went
> >> wrong with the release?
> >> Immediately after the release, even the Solaris buildbot complained
> >> about a broken build.
> >
> > I thought that the buildbot runs on each push to git repository !?
> > If so, how can the last commit (the 1.17.1 tagged commit) cause a failure
> > on did not come up before ? Bug in the gnulib module ?
> >
> >
> > The error does tell me nothing:
> > (This is from the buildbot output)
> >
> > gmake[3]: Entering directory '/export/home/buildbot/slave/wget-solaris10-
> > i386/build/src'
> > /opt/csw/bin/gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/usr/local/etc/wgetrc\"
> > - DLOCALEDIR=\"/usr/local/share/locale\" -I. -I../lib -I../lib
> > -D_REENTRANT - I/opt/csw/include -I/opt/csw/include -I/opt/csw/include
> > -I/opt/csw/include -I/opt/csw/include/p11-kit-1 -DHAVE_LIBGNUTLS
> > -I/opt/csw/include - I/opt/csw/include -DNDEBUG -MT connect.o -MD
> > -MP -MF .deps/connect.Tpo -c - o connect.o connect.c
> > In file included from /usr/include/sys/types.h:17:0,
> >
> > from ../lib/sys/types.h:28,
> > from sysdep.h:85,
> > from wget.h:47,
> >
> > from connect.c:32:
> > /opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include-
> > fixed/sys/feature_tests.h:346:2: error: #error "Compiler or options
> > invalid
> > for pre-UNIX 03 X/Open applications and pre-2001 POSIX applications"
> >
> > #error "Compiler or options invalid for pre-UNIX 03 X/Open applications \
> >
> > ^
> >
> > Tim
> >
> >> On 12 December 2015 at 17:42, Christian Jullien <address@hidden> wrote:
> >> > Hi, trying to compile wget-1.17 and now wget-1.17.1 on solaris 10 sparc
> >> > using gcc 5.2.0 , I get:
> >> >
> >> >
> >> >
> >> > hsts.c:505:11: warning: implicit declaration of function 'flock'
> >> > [-Wimplicit-function-declaration]
> >> >
> >> > flock (fd, LOCK_EX);
> >> >
> >> > ^
> >> >
> >> > hsts.c:505:22: error: 'LOCK_EX' undeclared (first use in this function)
> >> >
> >> > flock (fd, LOCK_EX);
> >> >
> >> > ^
> >> >
> >> > hsts.c:505:22: note: each undeclared identifier is reported only once
> >> > for
> >> > each function it appears in
> >> >
> >> > Makefile:1573: recipe for target 'hsts.o' failed
> >> >
> >> >
> >> >
> >> > I solved compilation issue by replacing flock (line 505) by lockf which
> >> > is
> >> > (POSIX.1-2001)
> >> >
> >> > => lockf (fd, F_LOCK, 0);
> >> >
> >> >
> >> >
> >> > Hope it helps.
> >> >
> >> >
> >> >
> >> > Christian
Re: [Bug-wget] flock is not available on solaris 10 (at least sparc), Tim Rühsen, 2015/12/12