bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Support non-ASCII URLs


From: Tim Rühsen
Subject: Re: [Bug-wget] Support non-ASCII URLs
Date: Fri, 18 Dec 2015 22:41:29 +0100
User-agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; )

Am Freitag, 18. Dezember 2015, 16:42:15 schrieb Giuseppe Scrivano:
> Eli Zaretskii <address@hidden> writes:
> > Attached.
> 
> great, thanks!  Tim, do you have any objections or can we push it?

Just two issues.

1. Maybe do_conversion() should take a char * argument instead of const char 
*. We avoid one ugly const -> non-const cast an also a warning about iconv.

2. contrib/check-hard fails with
TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8 VALGRIND_TESTS=0" make check

FAIL: Test-iri-forced-remote

My son has birthday tomorrow, so I am not sure how much time I can spend on 
the weekend on this issue. Maybe Eli or you could have a look ?

Regards, Tim




reply via email to

[Prev in Thread] Current Thread [Next in Thread]