>From ba82c1a00b3f3c9e6296a8a8e811e8270dbd9ec7 Mon Sep 17 00:00:00 2001 From: Ander Juaristi Date: Sun, 13 Dec 2015 00:13:31 +0100 Subject: [PATCH] Fix potential leak * src/hsts.c (hsts_store_open): close fp if open. * src/ftp.c (getftp): fix compiler warning for unused variable. --- src/ftp.c | 1 - src/hsts.c | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ftp.c b/src/ftp.c index 002842e..cc90c3d 100644 --- a/src/ftp.c +++ b/src/ftp.c @@ -322,7 +322,6 @@ getftp (struct url *u, wgint passed_expected_bytes, wgint *qtyread, int csock, dtsock, local_sock, res; uerr_t err = RETROK; /* appease the compiler */ FILE *fp = NULL; - struct_fstat st; char *respline, *tms; const char *user, *passwd, *tmrate; int cmd = con->cmd; diff --git a/src/hsts.c b/src/hsts.c index 1583659..af7ade1 100644 --- a/src/hsts.c +++ b/src/hsts.c @@ -485,10 +485,12 @@ hsts_store_open (const char *filename) if (fstat (fileno (fp), &st) == 0) store->last_mtime = st.st_mtime; - fclose (fp); } out: + if (fp) + fclose (fp); + return store; } -- 2.1.4