Re: [Bug-wget] Support non-ASCII URLs

[Giuseppe Scrivano]

Eli Zaretskii <address@hidden> writes:

>> From: Tim Rühsen <address@hidden>
>> Cc: Giuseppe Scrivano <address@hidden>, Eli Zaretskii <address@hidden>
>> Date: Fri, 18 Dec 2015 22:41:29 +0100
>> 
>> 1. Maybe do_conversion() should take a char * argument instead of const char 
>> *. We avoid one ugly const -> non-const cast an also a warning about iconv.
>
> I agree.
>
>> 2. contrib/check-hard fails with
>> TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8 VALGRIND_TESTS=0" make check
>> 
>> FAIL: Test-iri-forced-remote
>> 
>> My son has birthday tomorrow, so I am not sure how much time I can spend on 
>> the weekend on this issue. Maybe Eli or you could have a look ?
>
> I cannot bootstrap the Git repo (too many prerequisites I don't have).
> Can you or someone else produce a distribution tarball out of Git that
> I could then build "as usual"?
>
> Also, can you show me the log of the failed test?  Turkish locales
> have "an issue" with certain upper/lower-case characters, maybe that's
> the problem.  Or maybe it's something else; looking at the log might
> give good clues.

sorry for taking so long, this is the log I get when I run

$ TESTS_ENVIRONMENT="LC_ALL=tr_TR.utf8 VALGRIND_TESTS=0" make check

===============================================
   wget 1.17.1.10-c78d: tests/test-suite.log
===============================================

# TOTAL: 85
# PASS:  84
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: Test-iri-forced-remote
============================

Unescaped left brace in regex is deprecated, passed through in regex; marked by 
<-- HERE in m/{{ <-- HERE port}}/ at HTTPServer.pm line 313.
Unescaped left brace in regex is deprecated, passed through in regex; marked by 
<-- HERE in m/{{ <-- HERE port}}/ at HTTPTest.pm line 50.
Running test Test-iri-forced-remote
Calling /home/gscrivano/src/wget/tests/../src/wget --iri -e robots=on 
--trust-server-names --remote-encoding=iso-8859-1 -nH -r http://localhost:36098/
--2016-01-12 12:11:57--  http://localhost:36098/
Resolving localhost (localhost)... 127.0.0.1
Connecting to localhost (localhost)|127.0.0.1|:36098... connected.
HTTP request sent, awaiting response... 200 Ok
Length: 279 [text/html]
Saving to: ‘index.html’

     0K                                                       100% 30,8M=0s

2016-01-12 12:11:57 (30,8 MB/s) - ‘index.html’ saved [279/279]

Loading robots.txt; please ignore errors.
--2016-01-12 12:11:57--  http://localhost:36098/robots.txt
Reusing existing connection to localhost:36098.
HTTP request sent, awaiting response... 200 Ok
Length: unspecified [text/plain]
Saving to: ‘robots.txt’

     0K                                                        0,00 =0s

2016-01-12 12:11:57 (0,00 B/s) - ‘robots.txt’ saved [0]

--2016-01-12 12:11:57--  http://localhost:36098/p1_fran%C3%A7ais.html
Connecting to localhost (localhost)|127.0.0.1|:36098... connected.
HTTP request sent, awaiting response... 200 Ok
Length: 278 [text/html]
Saving to: ‘p1_français.html’

     0K                                                       100% 32,7M=0s

2016-01-12 12:11:57 (32,7 MB/s) - ‘p1_français.html’ saved [278/278]

--2016-01-12 12:11:57--  http://localhost:36098/p3_%C2%A4%C2%A4%C2%A4.html
Reusing existing connection to localhost:36098.
HTTP request sent, awaiting response... 200 Ok
Length: 119 [text/plain]
Saving to: ‘p3_¤¤¤.html’

     0K                                                       100% 13,9M=0s

2016-01-12 12:11:57 (13,9 MB/s) - ‘p3_¤¤¤.html’ saved [119/119]

--2016-01-12 12:11:57--  http://localhost:36098/p2_%C3%A9%C3%A9n.html
Reusing existing connection to localhost:36098.
HTTP request sent, awaiting response... 200 Ok
Length: 254 [text/html]
Saving to: ‘p2_één.html’

     0K                                                       100% 26,2M=0s

2016-01-12 12:11:57 (26,2 MB/s) - ‘p2_één.html’ saved [254/254]

FINISHED --2016-01-12 12:11:57--
Total wall clock time: 0,09s
Downloaded: 5 files, 930 in 0s (26,0 MB/s)
Test failed: file p1_français.html not downloaded
FAIL Test-iri-forced-remote.px (exit status: 1)