bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Patch for understanding srcset= on img tags.


From: Maksim Orlovich
Subject: Re: [Bug-wget] Patch for understanding srcset= on img tags.
Date: Tue, 1 Mar 2016 10:01:40 -0500

> thanks for your patch!  I have some comments.  Please amend this:
>
> diff --git a/src/html-url.c b/src/html-url.c
> index dff8d57..2f205c7 100644
> --- a/src/html-url.c
> +++ b/src/html-url.c
> @@ -692,8 +692,8 @@ tag_handle_img (int tagid, struct taginfo *tag, struct 
> map_context *ctx) {
>    if (srcset)
>      {
>        /* These are relative to the input text. */
> -      int base_ind = ATTR_POS(tag,attrind,ctx);
> -      int size = strlen(srcset);
> +      int base_ind = ATTR_POS (tag, attrind, ctx);
> +      int size = strlen (srcset);

Done.


> should the condition be (c == ')' && in_paren)  ?

Indeed.

Thanks,
Maks

Attachment: wget-srcset-patch2.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]