[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-wget] Win32, assert() in progress.c
From: |
Gisle Vanem |
Subject: |
[Bug-wget] Win32, assert() in progress.c |
Date: |
Sat, 5 Mar 2016 10:33:51 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
Darshit (?), the progress.c change to add the assert() at line 1167:
assert (padding > 0 && "Padding length became non-positive!");
always triggers on MSVC-2015 and TDM-gcc (w/o -DNDEBUG).
Not sure it's because of 'determine_screen_width()',
'USE_NLS_PROGRESS_BAR=1' or something else, but a:
assert (padding >= 0 && "Padding length became non-positive!");
fixes it. Some off-by-1 calculation?
BTW,
here is what it looks like on Win-10 (120 x 50 screen):
http://watt-32.net/misc/wget-progress-1.png (default --progress=bar)
http://watt-32.net/misc/wget-progress-2.png (-q --show-progress)
with a modified patch of Jernej Simončič Windows TaskBar feature:
https://eternallybored.org/misc/wget/src/taskbar-progress.patch
--
--gv
- [Bug-wget] Win32, assert() in progress.c,
Gisle Vanem <=