[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys

From: moparisthebest
Subject: Re: [Bug-wget] Implement --pinnedpubkey option to pin public keys
Date: Mon, 4 Apr 2016 12:28:47 -0400

Hi all,

I have now implemented tests for --pinnedpubkey, the first patch is
unchanged from last time, the second patch has all the new test code.

They all pass as long as I export SSL_TESTS as an environmental variable
(otherwise they are skipped), I see there is code in Makefile.am that
supposedly does that, but it's not working for me, likely because I'm
doing something wrong...

Let me know if there is anything else I can do.


On 03/18/2016 02:10 AM, moparisthebest wrote:
> Hi Tim,
> I've implemented your suggestions below, except the python tests, and
> rebased on top of current HEAD, attached is the patch.
> The documentation in testenv/ says the test server doesn't support
> https, which would be needed for this test.  Has anyone started work on
> that?  Or would it be acceptable to just use socat or stunnel or similar
> in front of the current test server?
> Thanks much,
> Travis
> On 03/15/2016 07:50 AM, Tim Ruehsen wrote:
>> Hi Travis,
>> thanks for poking. I started testing... just a few more points.
>> In wg_pin_peer_pubkey(), what is this loop do {...} while(0) about ?
>> I looks like it is not supposed to loop (if it would, we had resource 
>> leaks). 
>> Maybe you can remove it and instead of 'break: do a 'goto end/cleanup/out' !?
>> Please consider to use wget_read_file / wget_read_file_free() for reading 
>> the 
>> contents of a file. It also allows for stdin ('-' at the command line) which 
>> makes the new option a bit more consistent with Wget's CLI standards.
>> Do you plan to create a python test (see testenv/) ?
>> Regards, Tim

Attachment: 0001-Implement-pinnedpubkey-option-to-pin-public-keys.patch
Description: Text Data

Attachment: 0002-Implement-tests-for-new-pinnedpubkey-option.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]