|
From: | Tim Ruehsen |
Subject: | [Bug-wget] [PATCH] Fix python test suite |
Date: | Fri, 08 Apr 2016 16:44:56 +0200 |
User-agent: | KMail/4.14.10 (Linux/4.4.0-1-amd64; KDE/4.14.14; x86_64; ; ) |
Travis' patches for --pinnedpubkey let me take a closer look into the python test suite today. I wondered why some tests PASSed though there were serious failures in the appropriate .log files. An exception raised in the post_hook did not make the test fail. Patch 0001-... handles this now. The reason for those exceptions was a copy&paste of the TEST_NAME value. This value is taken as test directory. And with a parallel test suite we suddenly have several tests running at the same time using the same directory. I already stumbled upon this in the past myself - and I am sure this will cost some work in future as well. Easily circumvented by using the file name of the test as test name. This is patch 0002-... just as suggestion, to complete it we have to remove all occurrences of TEST_NAME from the python tests. The fix/patch 0001-... brought up a broken test case (fails in post_hook) which is fixed in 0003-... Please review & comment Tim
0001-Fail-python-tests-when-post_hook-errors.patch
Description: Text Data
0002-Use-test-file-name-as-TEST_NAME.patch
Description: Text Data
0003-Fix-testenv-Test-rejected-log.py.patch
Description: Text Data
signature.asc
Description: This is a digitally signed message part.
[Prev in Thread] | Current Thread | [Next in Thread] |