Re: [Bug-wget] 'Saving HSTS entries to' bug

[Tim Ruehsen]

Hi Ander,

after applying your patch I still see changes in store->table (resp. changes 
of the contents of the entries) without tagging store as changed.

Everywhere you change something that gets dumped to the disk database *must* 
set the store->changed flag.

For example:
Executing
        wget -d www.yahoo.com
twice shows updating the HSTS database only for the first time (taking a nap 
of two seconds between) - the max_age should be updated in the database for 
both invocations.

Tim

On Tuesday 24 May 2016 12:26:39 Ander Juaristi wrote:
> Yes, I guess you're right.
> 
> Have a look at this.
> 
> On 24/05/16 11:48, Tim Ruehsen wrote:
> >> But
> >> again, I don't think it pays off for the sole reason of removing a debug
> >> message.
> > 
> > Sorry, I forgot to mention, that it is about writing the database when it
> > is not needed. Just think of someone having a larg HSTS database in
> > combination with lot's of short-live invocations of wget.
> > 
> > Tim

signature.asc
Description: This is a digitally signed message part.