[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Trivial changes in HSTS
|
From: |
Ander Juaristi |
|
Subject: |
Re: [Bug-wget] [PATCH] Trivial changes in HSTS |
|
Date: |
Wed, 25 May 2016 22:14:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
Hi,
On 24/05/16 21:10, Tim Rühsen wrote:
>
> Hi Ander,
>
> could you rearrange the code in hsts_store_open() a bit to
> - avoid double calling file_exists_p (filename)
> - reduce the scope of 'st' and 'fp'
>
> if (file_exists_p (filename)) {
> if (hsts_file_access_valid (filename)) {
> struct_stat st;
> FILE *fp = fopen (filename, "r");
> ...
> } else {
> ...
> }
>
> out:
> return store;
> }
How about this?
>
> Regards, Tim
>
Regards,
- AJ
0001-Check-the-HSTS-file-is-not-world-writable.patch
Description: Text Data