[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Progress bar on MS-Windows

From: Eli Zaretskii
Subject: Re: [Bug-wget] Progress bar on MS-Windows
Date: Sat, 04 Jun 2016 11:27:56 +0300

> Date: Wed, 1 Jun 2016 10:28:35 +0200
> From: Darshit Shah <address@hidden>
> Cc: address@hidden
> Can you please try with the latest HEAD once? As far as I am aware, all 
> the off-by-one errors have been fixed.

Sorry, no.  Not unless someone will be kind enough to produce a
complete tarball.  Building from Git requires all kinds of utilities
that are not simple to set up on Windows.

In any case, I did look at the latest sources in Git, and I don't
think the patch I suggested is fixed, because the calculation in
determine_screen_width didn't change.  The problem here is that the
Windows cmd console moves to the next line as soon as you display the
last character that fits on the line.  So the last column must never
be occupied if we want a proper progress display.

> If there is something left over, we should fix it in the progress bar 
> output itself instead of a hack somewhere in the Windows specific code.  

It's not a hack.

> Unless the issue is in how the window size is reported in Windows.

It is.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]