Re: [Bug-wget] 'Reading HSTS entries from' bug

[Tim Ruehsen]

On Wednesday 22 June 2016 23:15:42 Ander Juaristi wrote:
> Hi,
> 
> On 20/06/16 16:12, . wrote:
> > it was not fixed completely for v1.18
> 
> I cannot reproduce it after the patch was merged upstream. The 'saving
> HSTS entries' text only appears when the HSTS file is updated.
> 
> I do see, however, that it still says 'Reading HSTS entries from...' in
> the beginning, even for non-HSTS hosts, and FTP. Is this what you mean?
> 
> The HSTS entries are read in the beginning, long before the URI is
> actually parsed. The only solution I can come across is to check if the
> scheme is FTP or FTPS, and not load the HSTS at all if affirmative. I
> forward to the list for discussion because I don't know if it's worth
> the effort.

We could 'lazy-load' it in retr.c/retrieve_url(), right before hsts_match().

That might be useful in some corner cases, where the HSTS database is very 
large and someone just downloads from FTP(S).

This seems not to be top priority. Could you add it to the bug tracker, so we 
don't forget it !?

Tim

signature.asc
Description: This is a digitally signed message part.