[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] wget: Add --ssh-askpass support
|
From: |
Eli Zaretskii |
|
Subject: |
Re: [Bug-wget] [PATCH] wget: Add --ssh-askpass support |
|
Date: |
Sun, 24 Jul 2016 05:33:31 +0300 |
> From: address@hidden (Jeremie Courreges-Anglas)
> Cc: "Liam R. Howlett" <address@hidden>, address@hidden
> Date: Sat, 23 Jul 2016 21:24:33 +0200
>
> > This implementation is unnecessarily non-portable ('fork' doesn't
> > exist on some supported platforms). I suggest to use a much more
> > portable 'popen' instead.
>
> popen(3) may be more portable but is it subject to all the problems
> brought by "sh -c": the string may contain shell metacharacters, etc.
Nothing command-line quoting cannot handle, surely.
> What worries me is the use of strace(1), which is afaik available only
> on Linux. OpenBSD for example doesn't have it. Why would strace(1) be
> needed here?
Right.