[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH 01/25] Add two Metalink/XML tests
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] [PATCH 01/25] Add two Metalink/XML tests |
Date: |
Tue, 13 Sep 2016 10:10:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi Matthew,
Matthew White <address@hidden> writes:
> Next patches add more conditions to testenv/Test-metalink-xml-relpath.py.
>
> Also variants are introduced, like:
> * testenv/Test-metalink-xml-trust.py
> * testenv/Test-metalink-xml-homepath.py
> * testenv/Test-metalink-xml-homepath-trust.py
> * testenv/Test-metalink-xml-abspath-trust.py
> * testenv/Test-metalink-xml-relpath-trust.py
>
> And there will be other tests with other meanings too.
>
> So, I don't know if it's a good idea to mix specific tests together.
>
> This topic also applies to Patch 05/25, Patch 10/25, and Patch 17/25:
> http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00046.html
> http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00050.html
> http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00057.html
>
> WDYT?
Could we have a base file, that is shared by these files? I agree it is
good to have a separate file for each different test, but if the
difference is only for one line, I think we can refactor them a bit. It
will make maintainance easier later.
Regards,
Giuseppe