[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Patch to change behavior with redirects under --r
From: |
Tim Ruehsen |
Subject: |
Re: [Bug-wget] [PATCH] Patch to change behavior with redirects under --recurse. |
Date: |
Fri, 07 Oct 2016 11:03:45 +0200 |
User-agent: |
KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.26.0; x86_64; ; ) |
On Wednesday, August 24, 2016 8:21:31 PM CEST Dale R. Worley wrote:
> This is the change that I'm interested in. I don't expect this to be
> put into the distribution without a lot of discussion.
>
> This version changes the behavior of --recurse: If a file is
> downloaded, it will be scanned for links to follow. This differs from
> the current behavior, in which the URL from which the contents were
> obtained (after any redirections) is further checked to see if that URL
> passes the recursion limitations.
>
> This patch also includes a test to verify the new behavior.
>
> I worry that this is a substantial change of behavior. OTOH, the
> current behavior seems to be very unintuitive. And the fact that there
> is no test for this behavior suggests that people have not been
> depending on it.
>
> Comments?
Hi Dale,
the changes in recur.c are not acceptable. They circumvent too many checks
like host-spanning, excludes and even --https-only.
Maybe leaving descend_redirect() and checking the returned reject reason could
solve your issue. I'll have a closer look at it soon.
Regards, Tim
signature.asc
Description: This is a digitally signed message part.
- Re: [Bug-wget] [PATCH] Patch to change behavior with redirects under --recurse.,
Tim Ruehsen <=