Re: [Bug-wget] [PATCH v2] bug #46584: wget --spider always returns zero exit status

[Tim Rühsen]

Thanks, pushed.

On Mittwoch, 19. Oktober 2016 11:53:23 CEST losgrandes wrote:
> * src/ftp.c: Return error as exit value if even one file doesn't exist
> 
> ---
>  src/ftp.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/ftp.c b/src/ftp.c
> index cc98ca3..77dc9cd 100644
> --- a/src/ftp.c
> +++ b/src/ftp.c
> @@ -1186,6 +1186,7 @@ Error in server response, closing control
> connection.\n")); if (opt.spider)
>          {
>            bool exists = false;
> +          bool all_exist = true;
>            struct fileinfo *f;
>            uerr_t _res = ftp_get_listing (u, original_url, con, &f);
>            /* Set the DO_RETR command flag again, because it gets unset when
> @@ -1201,6 +1202,8 @@ Error in server response, closing control
> connection.\n")); {
>                        exists = true;
>                        break;
> +                    } else {
> +                      all_exist = false;
>                      }
>                    f = f->next;
>                  }
> @@ -1221,7 +1224,11 @@ Error in server response, closing control
> connection.\n")); con->csock = -1;
>            fd_close (dtsock);
>            fd_close (local_sock);
> -          return RETRFINISHED;
> +          if (all_exist) {
> +              return RETRFINISHED;
> +          } else {
> +              return FTPNSFOD;
> +          }
>          }
> 
>        if (opt.verbose)

signature.asc
Description: This is a digitally signed message part.