[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-wget] [bug #48811] netrc password wins over interactive --ask-passw

From: Tim Ruehsen
Subject: [Bug-wget] [bug #48811] netrc password wins over interactive --ask-password
Date: Tue, 20 Dec 2016 09:57:46 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Follow-up Comment #3, bug #48811 (project wget):

Thanks for working on this.

If you are working on that code anyways, please consider making it more
readable, e.g. like
  if (u->user)
    *user = u->user;
  else if (opt.http_user)
    *user = opt.http_user;
  else if (opt.user)
    *user = opt.user;

 ... same for passwd ...

  if (opt.netrc && (!*user || !*password))
    search_netrc (u->host, (const char **)user, (const char **)passwd, 0);

But that is not all... when opt.use_askpass is set and the user/password have
been retrieved by that mechanism, these values should have priority over
opt.http|ftp_user / opt.http|ftp_passwd, right ?

Similar with opt.ask_passwd.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]