Re: [Bug-wget] patch: Stored file name coversion logic correction

[Tim Ruehsen]

On Wednesday, February 15, 2017 7:12:16 PM CET YX Hao wrote:
> Hi there,
> 
> 
> 
> I got this on a non-ASCII environment. The local path contains non-ASCII
> characters with OEM ANSI encoded. So, we should convert the server responded
> file name before it is concatenated to the local path. Not after that. Or,
> it will cause error in the next 'iconv' function .

Hi,

sounds reasonable, but please provide further info to reproduce the issue.

I have a non-ASCII environment as well, and moved the whole Wget project into 
some non-ASCII subdirectory (äöü/). At least some of the *-iri-* should have 
failed, but all succeeded.

Btw, your patch introduces a memory leak (fname_len_check will be 
overwritten). And what about the 'else' case ?

Regards, Tim

signature.asc
Description: This is a digitally signed message part.