Re: [Bug-wget] `make check` fails 4 tests on fresh wget2 clone

[Tim Ruehsen]

On Thursday, March 23, 2017 1:07:12 PM CET Avinash Sonawane wrote:
> Hello!
> 
> I just cloned the fresh wget2 repo and did `make check` but it failed
> for 4 tests. I haven't configured to use valgrind.
> 
> Is this an expected behavior?
> 
> Here is the tests/test-suite.log http://pastebin.com/g1crJBJ7
> 
> PS - No. I'm not using proxy connection. Also I haven't set any proxy
> variables.

You should have libidn2/libidn2-dev (IDNA 2008 + TR46) installed. If that is 
not possible, the old libidn/libidn-dev (IDNA 2003, suffers from some security 
issues, but still pretty common) will do it in this case as well.
BTW, the curl project recently decided to use libidn2 only.

If you don't have either, wget2 is still compilable but just works with pure 
ASCII domain names.

BTW, the message 'toASCII not available:' is directly in the code you are just 
working on (wget_str_to_ascii()) :-)

We could:
1. Skip those tests if IDNA is not available
2. Make IDNA 200x a hard build prerequisite

WDYT ?

Regards, Tim

signature.asc
Description: This is a digitally signed message part.