[Bug-wget] Problems with (not) building wget against libiconv

[Mojca Miklavec]

Hi,

I'm experiencing a recent regression in wget builds. It worked fine in
version 1.17.1 and it fails now with 1.19.1.

I can do some bisection, but I guess I could blame at least the
following commit:

http://git.savannah.gnu.org/cgit/wget.git/commit/src/url.c?id=7e585fe23dd69cadfc3f44df0c5f8bc47ab37cbb

that has not been properly restored in

http://git.savannah.gnu.org/cgit/wget.git/commit/src/url.c?id=517d799b6f94e60e302806a2daa14c7a4ac3fbbd

but more importantly: m4/gnulib-comp.m4 seems to opportunistically
define HAVE_ICONV even if I try to do my best not to.


We need portable wget binaries just for the sake of downloading a few
packages. This is why we try to exclude as many libraries as possible
(the only other alternative would be to build them statically). The
biggest problem arises when the build machine has a certain package
that cannot be found on the target machine.

We configure wget with

--enable-ipv6 --disable-iri --disable-nls --disable-ntlm
--disable-pcre --without-libiconv-prefix --without-libintl-prefix
--without-libuuid --without-libpsl --without-ssl --without-zlib

and the build fails both on Solaris 10 (on the same buildfarm as you
are using) and on Mac OS X 10.6.

Both say:
    checking for iconv.h... yes

And then fail in the last step (with url.o containing iconv symbols).

Solaris:

  CCLD     wget
Undefined first referenced
 symbol      in file
libiconv_close                      url.o  (symbol belongs to implicit
dependency /opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/../../../libiconv.so.2)
libiconv_open                       url.o  (symbol belongs to implicit
dependency /opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/../../../libiconv.so.2)
libiconv                            url.o  (symbol belongs to implicit
dependency /opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/../../../libiconv.so.2)
ld: fatal: symbol referencing errors. No output written to wget
collect2: error: ld returned 1 exit status


Mac:

  CCLD     wget
Undefined symbols:
  "_iconv_close", referenced from:
      _convert_fname in url.o
      _convert_fname in url.o
  "_iconv", referenced from:
      _convert_fname in url.o
      _convert_fname in url.o
  "_iconv_open", referenced from:
      _convert_fname in url.o
ld: symbol(s) not found
collect2: ld returned 1 exit status


I would be grateful if this could be fixed.

Mojca