bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] PATCH: tests for SSL


From: Tim Rühsen
Subject: Re: [Bug-wget] PATCH: tests for SSL
Date: Fri, 28 Apr 2017 09:13:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Hi Vijo,

first of all, thank you very much for your great contribution !

I review (and hopefully check in) your patch today.

On 04/28/2017 02:42 AM, Vijo Cherian wrote:
> Looking at wget2, there doesn't  seem to be any perl based tests there at
> all.
> Is there any decisions regarding test scripts that are planned for wget2?
> Is it OK to "port" wget perl scripts to wget2?

We definitely won't use Perl for Wget2. The tests are simple C programs,
even easy to maintain for someone not so familiar with C.
It's more the test content that matters (options for wget, files on the
server, requests and responses).

With Best Regards, Tim


> Best,
> Vijo.
> 
> 
> On Wed, Apr 26, 2017 at 9:19 PM, Vijo Cherian <address@hidden> wrote:
> 
>> Thank you Tim.
>>
>> Attached is the last set of patches from me for SSL testing.
>> I will apply these to wget2 and start working on wget2 from now.
>>
>> Best,
>> Vijo.
>>
>>
>> On Wed, Apr 19, 2017 at 4:12 AM, Tim Rühsen <address@hidden> wrote:
>>
>>> Hi Vijo,
>>>
>>> On 04/18/2017 06:56 PM, Vijo Cherian wrote:
>>>> Added a framework for perl based SSL tests, and some tests to start
>>> with.
>>>> In case this is of interest, I will add more tests for SSL: client
>>>> certificates, CRLs, negative tests etc.
>>>> Also not included : making these tests a part of "make check".
>>>>
>>>> TESTING :  only on ubuntu 16
>>>
>>> thank you for this contribution !
>>>
>>> Your commit has been slightly amended (trailing white space removed,
>>> commit message changed to GNU style) and pushed to master.
>>>
>>> Maybe you are interested to inspect Wget2 testing to see if your tests
>>> are already covered there. If not we would be pleased if you could add
>>> them there as well.
>>>
>>> Just 'git clone https://github.com/rockdaboot/wget2' and jump in !
>>>
>>> Regards, Tim
>>>
>>>
>>
> 

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]