Re: [Bug-wget] wget2 fails to build if spaces in directory path

[Akash Rawal]

On 06/26/2017 10:28 PM, Avinash Sonawane wrote:
> On Mon, Jun 26, 2017 at 3:49 PM, chris <address@hidden> wrote:
> > Sure:
> >
> > https://gist.github.com/anfractuosity/0a9c12f81ebbb1033883bbec28b62dcd
>
> This is happening because absolute paths have been used in Makefiles.
> Please find the attached patch which fixes the issue. Sorry, haven't
> sent the merge request to upstream as `make check` still fails. but
> you can do 'make' and 'sudo make install' the wget2.
We use absolute paths because relative paths break tests when build
tree is separate from source tree.
    mkdir build
    cd build
    ../configure && make && make check
The reason the make check fails is that test program cd's to a
subdirectory to run tests. After changing directory, the
relative path is no longer correct. To further complicate the issue,
srcdir and top_srcdir are not guaranteed to be relative paths.
> Apply the patch to your local git wget2 repo (git apply) if you are
> keen on building the wget2 at a location with spaces in it's absolute
> path.
>
> Regards,
> Avinash Sonawane (rootKea)
> PICT, Pune
> https://rootkea.wordpress.com
Regards,
Akash Rawal