[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-wget] [bug #51576] wget incorrectly uses strncmp() and similar in m
|
From: |
Tim Ruehsen |
|
Subject: |
[Bug-wget] [bug #51576] wget incorrectly uses strncmp() and similar in many places |
|
Date: |
Fri, 28 Jul 2017 10:41:59 -0400 (EDT) |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 |
Follow-up Comment #1, bug #51576 (project wget):
Thanks for pointing out this generic type of error.
The NTLM check is done a bit sloppy, but I can't see no harm here except that
the authentication will fail.
As you say, normally strncmp and strcasencmp are just used to check if a
string begins with a certain sequence.
The code found by you in http.c seems indeed to be wrong. 'type' is
0-terminated and there is no reason to not use strcasecmp() (and it should be
c_strcasecmp here as well).
I'll skim the code to see if there is more.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?51576>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/