bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to loc


From: Eli Zaretskii
Subject: Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded
Date: Sun, 12 Nov 2017 20:46:33 +0200

> From: Tim Rühsen <address@hidden>
> Date: Sun, 12 Nov 2017 14:50:47 +0100
> Cc: YX Hao <address@hidden>
> 
> As I understand, the second patch is still in discussion with Eli. Since I do 
> not have Windows, I can't help you here. Though what I saw from the 
> discussion, you address a portability issue that likely should be solved 
> within gnulib. Maybe you could (in parallel) send a mail to address@hidden 
> with a link to your discussion with Eli. There might be some people with 
> deeper knowledge.

I don't think it's a Gnulib issue.  The problem is that on Windows,
the implicit call at the beginning of Wget

  setlocale (LC_ALL, "C");

is not good enough to work in multibyte locales of the Far East,
because the Windows runtime assumes a single-byte locale after that
call.  And since Wget happens to need to display text and create files
with non-ASCII characters, it gets hit more than other programs.

The proposed solution is to add a special call to setlocale which gets
this right on Windows.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]