bug-wget
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [Win32] fork_to_background() broken


From: Tim Ruehsen
Subject: Re: [Bug-wget] [Win32] fork_to_background() broken
Date: Wed, 21 Feb 2018 19:06:37 +0100

Thanks, pushed.

Am Mittwoch, den 21.02.2018, 17:30 +0100 schrieb Gisle Vanem:
> The recent change of prototype of 'fork_to_background()'
> broke the Windows build:
>    mswindows.c(329,1) :  error: conflicting types for
> 'fork_to_background'
>    fork_to_background (void)
>    ^
>    ./utils.h(74,6) :  note: previous declaration is here
>    bool fork_to_background (void);
>         ^
> 
> A simplistic patch:
> 
> --- a/src/mswindows.c 2018-02-21 16:03:16
> +++ b/mswindows.c     2018-02-21 16:24:06
> 
> @@ -312,7 +312,7 @@
> 
>   /* This is the corresponding Windows implementation of the
>      fork_to_background() function in utils.c.  */
> -void
> +bool
>   fork_to_background (void)
>   {
>     int rv;
> @@ -332,6 +345,18 @@
>         abort ();
>       }
>     /* If we get here, we're the child.  */
> +  return false;
>   }
> 
> (ignoring the 'logfile_changed' stuff).
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]