Re: [Bug-wget] Bugs in make check in wget2 on mac

[Tim Rühsen]

Hi Dirk,

On 4/2/19 11:09 PM, Dirk Loeckx wrote:
> Dear Shah,
> 
> Attached you can find the output of ./configure, nothing special I have the
> impression.
> 
> The output of `./unit-tests/test-parse-html` is very short:
> 
>> dloeckx$ ./unit-tests/test-parse-html
>> dyld: Library not loaded: /usr/local/opt/libidn2/lib/libidn2.4.dylib
>>   Referenced from: /usr/local/opt/libpsl/lib/libpsl.5.dylib
>>   Reason: image not found
>> Abort trap: 6

As it looks like, you have libpsl installed without the proper libidn2.
This could have happened when you updated libidn2 without updating
libpsl - or by removing libidn2. Please check the above library paths
and fix it.

An alternative would be to build wget2 without libpsl, using
--without-libpsl as ./configure flag.

Regards, Tim

>>
> Vriendelijke groeten,
> Kind regards,
> 
> Dirk Loeckx
> 
> 
> address@hidden :: T +32 486 68 38 33 :: zeronary.care
> zeronary.care is an initiative of Jomale bvba :: VAT BE 0597.858.312
> 
> 
> On Tue, 2 Apr 2019 at 18:18, Darshit Shah <address@hidden> wrote:
> 
>> Two things here:
>>
>> 1. `configure` should have handled the case where you don't have
>> libmicrohttpd
>>    installed. So `make -C tests` should not have failed. Could you please
>> share
>>    the entire output of `./configure`?
>>
>> 2. What happens if you try to run `./unit-tests/test-parse-html`?
>>
>> I'm guessing there is something happening with clang here. Some
>> optimization
>> which is either buggy, or the more likely case is picking up on undefined
>> behaviour in Wget2.
>>
>> * Dirk Loeckx <address@hidden> [190402 17:52]:
>>> Dear Tim,
>>>
>>> Thanks for the quick response. I know I am a little bit out of scope, so
>>> don't feel obliged to fix this.
>>>
>>> Unfortunately, the make -C commands also both fail (attached the log
>> file):
>>>
>>>> dloeckx$ make check -C unit-tests
>>>> /Applications/Xcode.app/Contents/Developer/usr/bin/make
>>>> buffer_printf_perf stringmap_perf test test-parse-html test-cond
>> test-dl
>>>> libalpha.la libbeta.la
>>>>   CC       buffer_printf_perf.o
>>>>   CCLD     buffer_printf_perf
>>>>   CC       stringmap_perf.o
>>>>   CCLD     stringmap_perf
>>>>   CC       test.o
>>>>   CCLD     test
>>>>   CC       test-parse-html.o
>>>>   CCLD     test-parse-html
>>>>   CC       test-cond.o
>>>>   CCLD     test-cond
>>>>   CC       test-dl.o
>>>>   CCLD     test-dl
>>>>   CC       libalpha_la-test-dl-dummy.lo
>>>>   CCLD     libalpha.la
>>>>   CC       libbeta_la-test-dl-dummy.lo
>>>>   CCLD     libbeta.la
>>>> /Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS
>>>> ../build-aux/test-driver: line 107: 40594 Abort trap: 6           "$@"
>>>
>>>> $log_file 2>&1
>>>> FAIL: test
>>>> ../build-aux/test-driver: line 107: 40613 Abort trap: 6           "$@"
>>>
>>>> $log_file 2>&1
>>>> FAIL: test-parse-html
>>>> ../build-aux/test-driver: line 107: 40632 Abort trap: 6           "$@"
>>>
>>>> $log_file 2>&1
>>>> FAIL: test-cond
>>>> ../build-aux/test-driver: line 107: 40651 Abort trap: 6           "$@"
>>>
>>>> $log_file 2>&1
>>>> FAIL: test-dl
>>>>
>>>>
>> ============================================================================
>>>> Testsuite summary for wget2 1.99.1
>>>>
>>>>
>> ============================================================================
>>>> # TOTAL: 4
>>>> # PASS:  0
>>>> # SKIP:  0
>>>> # XFAIL: 0
>>>> # FAIL:  4
>>>> # XPASS: 0
>>>> # ERROR: 0
>>>>
>>>>
>> ============================================================================
>>>> See unit-tests/test-suite.log
>>>> Please report to address@hidden
>>>>
>>>>
>> ============================================================================
>>>> make[2]: *** [test-suite.log] Error 1
>>>> make[1]: *** [check-TESTS] Error 2
>>>> make: *** [check-am] Error 2
>>>> dloeckx$ make check -C tests
>>>>   CC       libtest_la-libtest.lo
>>>> libtest.c:46:10: fatal error: 'microhttpd.h' file not found
>>>> #include <microhttpd.h>
>>>>          ^~~~~~~~~~~~~~
>>>> 1 error generated.
>>>> make: *** [libtest_la-libtest.lo] Error 1
>>>> dloeckx$
>>>>
>>>
>>>
>>> Vriendelijke groeten,
>>> Kind regards,
>>>
>>> Dirk Loeckx
>>>
>>>
>>> address@hidden :: T +32 486 68 38 33 :: zeronary.care
>>> zeronary.care is an initiative of Jomale bvba :: VAT BE 0597.858.312
>>>
>>>
>>> On Tue, 2 Apr 2019 at 16:32, Tim Rühsen <address@hidden> wrote:
>>>
>>>> Hi Dirk,
>>>>
>>>> thanks for reporting.
>>>>
>>>> The only "Mac" we regularly test on is the OSX environment of TravisCI
>>>> (a continuous integration service). We don't have such errors there.
>>>>
>>>> Looks like there is something basically going wrong with the test
>>>> harness in fuzz/.
>>>>
>>>> If 'make check -C unit-tests' and 'make check -C tests' work OK for
>> you,
>>>> then you are likely fine with using wget2.
>>>>
>>>> If you know a Mac developer, you could ask that person to take a closer
>>>> look.
>>>>
>>>> Regards, Tim
>>>>
>>>> On 4/2/19 1:34 PM, Dirk Loeckx wrote:
>>>>> Dear,
>>>>>
>>>>> First of all thank you very much for building wget2!
>>>>>
>>>>> Following the instructions on
>>>>> https://react-etc.net/page/install-wget2-macos-mac-os-x and
>>>>> https://gitlab.com/gnuwget/wget2#building-from-git , I tried to
>> compile
>>>> and
>>>>> install wget2 on macOs (latest version).
>>>>>
>>>>> Unfortunately, I got a bug during 'make check', with the kind
>> request to
>>>>> report.
>>>>>
>>>>>> Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS
>>>>>> ../build-aux/test-driver: line 107: 34502 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_atom_url_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34521 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_bar_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34540 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_base64_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34559 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_cookie_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34578 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_css_url_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34597 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_hpkp_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34616 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_hsts_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34635 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_html_url_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34654 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_http_client_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34673 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_http_parse_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34692 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_iri_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34711 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_metalink_parse_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34730 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_netrc_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34749 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_ocsp_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34768 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_robots_parse_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34787 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_sitemap_url_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34806 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_tlssess_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34825 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_utils_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34844 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: libwget_xml_parse_buffer_fuzzer
>>>>>> ../build-aux/test-driver: line 107: 34863 Abort trap: 6
>>  "$@" >
>>>>>> $log_file 2>&1
>>>>>> FAIL: wget_options_fuzzer
>>>>>>
>>>>>>
>>>>
>> ============================================================================
>>>>>> Testsuite summary for wget2 1.99.1
>>>>>>
>>>>>>
>>>>
>> ============================================================================
>>>>>> # TOTAL: 20
>>>>>> # PASS:  0
>>>>>> # SKIP:  0
>>>>>> # XFAIL: 0
>>>>>> # FAIL:  20
>>>>>> # XPASS: 0
>>>>>> # ERROR: 0
>>>>>>
>>>>>>
>>>>
>> ============================================================================
>>>>>> See fuzz/test-suite.log
>>>>>> Please report to address@hidden
>>>>>>
>>>>>>
>>>>
>> ============================================================================
>>>>>> make[3]: *** [test-suite.log] Error 1
>>>>>> make[2]: *** [check-TESTS] Error 2
>>>>>> make[1]: *** [check-am] Error 2
>>>>>> make: *** [check-recursive] Error 1
>>>>>>
>>>>>
>>>>> Vriendelijke groeten,
>>>>> Kind regards,
>>>>>
>>>>> Dirk Loeckx
>>>>>
>>>>>
>>>>> address@hidden :: T +32 486 68 38 33 :: zeronary.care
>>>>> zeronary.care is an initiative of Jomale bvba :: VAT BE 0597.858.312
>>>>>
>>>>
>>>>
>>
>>
>>
>> --
>> Thanking You,
>> Darshit Shah
>> PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6
>>
>

signature.asc
Description: OpenPGP digital signature