[PATCH] no_proxy domain matching

[Tomas Hozza]

Hi.

In RHEL-8, we ship a wget version that suffers from bug fixed by [1]. The fix 
resolved issue with matching subdomains when no_proxy domain definition was 
prefixed with dot, e.q. "no_prefix=.mit.edu". As part of backporting the fix to 
RHEL, I wanted to create an upstream test for no_prefix functionality. However 
I found that there is still one corner case, which is not handled by the 
current upstream code and honestly I'm not sure what is the intended domain 
matching behavior in that case. Man page is also not very specific in this 
regard.

The corner case is as follows:
- no_proxy=.mit.edu
- download URL is e.g. "http://mit.edu/file1";

In this case the proxy settings are used, because domains don't match due to 
the leftmost dot in no_proxy domain definition. This is either intended or 
corner case that was not considered. One could argue, that if the no_proxy is 
set to ".mit.edu", then leftmost dot means that the proxy settings should not 
apply only to subdomains of "mit.edu", but proxy settings should still apply to 
"mit.edu" domain itself. From my point of view, after reading wget man page, I 
don't think that the leftmost dost in no_proxy definition has any special 
meaning.

I think that this corner case should be either fixed, or alternatively wget 
manpage should be made more specific about the intended behavior.

Anyway, I'm attaching patches fixing the corner case and adding test case for 
no_proxy behavior. And one small fix for the test framework - HttpTest begin() 
function was not returning a result value, but always None.

Please let me know if the corner case is really an intended behavior and I'll 
change the test case and can fix the man page instead of the code.

[1] 
http://git.savannah.gnu.org/cgit/wget.git/commit/?id=fd85ac9cc623847e9d94d9f9241ab34e2c146cbf

Thank you.

Regards,
Tomas
-- 
Tomas Hozza
Associate Manager, Software Engineering - EMEA ENG Core Services

PGP: 1D9F3C2D
UTC+2 (CEST)
Red Hat Inc.                 http://cz.redhat.com

0001-testenv-HTTPTest.begin-should-return-exit-value.patch
Description: Text Data

0002-testenv-Allow-definition-of-environment-variables-fo.patch
Description: Text Data

0003-testenv-Add-test-for-handling-of-no_proxy-environmen.patch
Description: Text Data

0004-src-host.c-Handle-a-corner-case-in-suffix-matching.patch
Description: Text Data