Re: [Bug-XBoard] Fix configure script for --enable-zippy

[Daniel Dugovic]

Hi,

I should have been clearer about the error I observed.  I use xboard to interface my chess engine with FICS so I use the zippyPlay feature.  Here's how to duplicate the error:

address@hidden xboard]$ autoconf -V
autoconf (GNU Autoconf) 2.59
Written by David J. MacKenzie and Akim Demaille.

Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

address@hidden xboard]$ uname -a
Linux dugovic.dyndns.org 2.6.18-308.20.1.el5 #1 SMP Tue Nov 13 10:15:12 EST 2012 x86_64 x86_64 x86_64 GNU/Linux

address@hidden xboard]$ sh autogen.sh
configure.ac:220: warning: AC_CANONICAL_HOST invoked multiple times
configure.ac:220: warning: AC_CANONICAL_HOST invoked multiple times
configure.ac:220: warning: AC_CANONICAL_HOST invoked multiple times
configure.ac: installing `./missing'
configure.ac:220: installing `./config.guess'
configure.ac:220: installing `./config.sub'
Makefile.am: installing `./compile'
Makefile.am: installing `./depcomp'
Makefile.am:75: installing `./mdate-sh'
Makefile.am:75: installing `./texinfo.tex'
configure.ac:220: warning: AC_CANONICAL_HOST invoked multiple times

address@hidden xboard]$ ./configure --enable-zippy && make
depbase=`echo zippy.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; \
if gcc -DHAVE_CONFIG_H -I. -I. -I. -DINFODIR='"/usr/local/info"' -I/usr/include/cairo -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/librsvg-2 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-2.0 -DSYSCONFDIR='"/usr/local/etc"' -DLOCALEDIR='"/usr/local/share/locale"' -DSVGDIR='"/usr/local/share/games/xboard/themes/default"' -I xaw -DX11 -Wall -Wno-parentheses -MT zippy.o -MD -MP -MF "$depbase.Tpo" -c -o zippy.o zippy.c; \
then mv -f "$depbase.Tpo" "$depbase.Po"; else rm -f "$depbase.Tpo"; exit 1; fi
zippy.c: In function âZippyInitâ:
zippy.c:116: error: âAppDataâ has no member named âzippyLinesâ
zippy.c:122: error: âAppDataâ has no member named âzippyPinheadâ
zippy.c:128: error: âAppDataâ has no member named âzippyPasswordâ
zippy.c:134: error: âAppDataâ has no member named âzippyPassword2â
zippy.c:140: error: âAppDataâ has no member named âzippyWrongPasswordâ
zippy.c:148: error: âAppDataâ has no member named âzippyAcceptOnlyâ
zippy.c:155: error: âAppDataâ has no member named âzippyUseIâ
zippy.c:162: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c:169: error: âAppDataâ has no member named âzippyNoplayCraftyâ
zippy.c:175: error: âAppDataâ has no member named âzippyGameEndâ
zippy.c:181: error: âAppDataâ has no member named âzippyGameStartâ
zippy.c:188: error: âAppDataâ has no member named âzippyAdjournâ
zippy.c:195: error: âAppDataâ has no member named âzippyAbortâ
zippy.c:201: error: âAppDataâ has no member named âzippyVariantsâ
zippy.c:203: error: âAppDataâ has no member named âzippyVariantsâ
zippy.c: In function âSpeakâ:
zippy.c:323: error: âAppDataâ has no member named âzippyUseIâ
zippy.c:330: error: âAppDataâ has no member named âzippyLinesâ
zippy.c: In function âZippyControlâ:
zippy.c:416: error: âAppDataâ has no member named âzippyNoplayCraftyâ
zippy.c:454: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c:461: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c:472: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c:483: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c:495: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c:504: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c:522: error: âAppDataâ has no member named âzippyPasswordâ
zippy.c:523: error: âAppDataâ has no member named âzippyPasswordâ
zippy.c:524: error: âAppDataâ has no member named âzippyPasswordâ
zippy.c:525: error: âAppDataâ has no member named âzippyPasswordâ
zippy.c:529: error: âAppDataâ has no member named âzippyPassword2â
zippy.c:530: error: âAppDataâ has no member named âzippyPassword2â
zippy.c:531: error: âAppDataâ has no member named âzippyPassword2â
zippy.c:532: error: âAppDataâ has no member named âzippyPassword2â
zippy.c:536: error: âAppDataâ has no member named âzippyWrongPasswordâ
zippy.c:537: error: âAppDataâ has no member named âzippyWrongPasswordâ
zippy.c:538: error: âAppDataâ has no member named âzippyWrongPasswordâ
zippy.c:539: error: âAppDataâ has no member named âzippyWrongPasswordâ
zippy.c:543: error: âAppDataâ has no member named âzippyBughouseâ
zippy.c: In function âZippyConverseâ:
zippy.c:598: error: âAppDataâ has no member named âzippyPinheadâ
zippy.c:599: error: âAppDataâ has no member named âzippyPinheadâ
zippy.c:726: error: âAppDataâ has no member named âzippyUseIâ
zippy.c: In function âZippyGameStartâ:
zippy.c:744: error: âAppDataâ has no member named âzippyGameStartâ
zippy.c:745: error: âAppDataâ has no member named âzippyGameStartâ
zippy.c: In function âZippyGameEndâ:
zippy.c:753: error: âAppDataâ has no member named âzippyAcceptOnlyâ
zippy.c:754: error: âAppDataâ has no member named âzippyGameEndâ
zippy.c:755: error: âAppDataâ has no member named âzippyGameEndâ
zippy.c:759: error: âAppDataâ has no member named âzippyShortGameâ
zippy.c: In function âZippyHandleChallengeâ:
zippy.c:794: error: âAppDataâ has no member named âzippyVariantsâ
zippy.c:800: error: âAppDataâ has no member named âzippyVariantsâ
zippy.c:807: error: âAppDataâ has no member named âzippyAcceptOnlyâ
zippy.c:808: error: âAppDataâ has no member named âzippyAcceptOnlyâ
zippy.c:815: error: âAppDataâ has no member named âzippyMaxGamesâ
zippy.c:817: error: âAppDataâ has no member named âzippyMaxGamesâ
zippy.c:818: error: âAppDataâ has no member named âzippyReplayTimeoutâ
zippy.c:821: error: âAppDataâ has no member named âzippyReplayTimeoutâ
zippy.c:828: error: âAppDataâ has no member named âzippyReplayTimeoutâ
zippy.c:832: error: âAppDataâ has no member named âzippyReplayTimeoutâ
zippy.c: In function âZippyMatchâ:
zippy.c:937: error: âAppDataâ has no member named âzippyAbortâ
zippy.c:954: error: âAppDataâ has no member named âzippyAdjournâ
make[2]: *** [zippy.o] Error 1
make[2]: Leaving directory `/home/dand/xboard'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/dand/xboard'
make: *** [all] Error 2

This was my next clue to the cause of the error:

address@hidden xboard]$ grep ZIPPY config.h
#define ZIPPY 0

Some experimentation with the configure script yielded that two lines were being generated:

#define ZIPPY 0

#define ZIPPY 1

and only the first of these was being appended to config.h.  This seems to contradict the autoconf documentation which says:

"If multiple AC_DEFINE statements are executed for the same variable name (not counting any parenthesized argument list), the last one wins."

but my revised approach seems less error-prone and it works on my machine generating only:

#define ZIPPY 1

and by default ./configure doesn't generate either statement and config.h contains:

/* #undef ZIPPY */

The difference between #if and #ifdef is that although both check if the parameter is defined, #if also checks if the value of that parameter is non-zero.  To me it seems simplest to only #define ZIPPY if we intend to use Zippy, and not care what the value of ZIPPY is as long as it's defined, so using #ifdef seems appropriate.

Thanks,

Daniel

On Mon, Nov 19, 2012 at 1:11 AM, Arun Persaud <address@hidden> wrote:

Hi

On 11/18/2012 10:21 AM, Daniel Dugovic wrote:
> I fixed a bug in the configure script which was causing compilation
> errors after ./configure --enable-zippy.  My changes can be seen here:
> http://github.com/ddugovic/xboard/commits/master
> http://github.com/ddugovic/xboard/commit/66fcdebff006d7d9a48f3cac4721864b4aae8c80
>

> I changed the configure.ac <http://configure.ac> script and changed

> source code files to use the simpler #ifdef ZIPPY instead of #if ZIPPY.

thanks for the patch, I should be able to apply it tomorrow.

Seems we had the enable/disable option the wrong way around in the
configure script. I don't get any compilation errors though with the
current setup?!

Also any reason to change from #if to #ifdef? I found a line that uses
an #ifndef, so I guess we should probably be using ifdef, but apart from
that they both seem to do the same thing.

cheers
        ARUN