Re: [Bug-XBoard] Xboard-hgbranch-master: Texture on the fly loading bug

[h . g . muller]

Op Ma, 29 februari, 2016 3:51 pm schreef Joshua Pettus:
> Thanks!  I’ll have to figure out the printf statements later tonight,
> things got a little busy over on my end :)

Don't bother, I found and fixed it. I had been trying to reproduce it only
by changing textures. But it turned out that changing the pieces was what
actually did it. The loop to replace pieces in ActivateTheme(), called
when OK-ing the View->Board dialog, was still assuming there would be 4
pieces behind King, as when there still were only 44 pieces this was were
the variant-specific replacements for Shogi +P, +L, +N and +S were stored.
Now that we have 66 pieces, these promo-Golds are part of the regular set
(so they can be used in any variant). So it was trying to delete pieces
that were never created, interpreting values outside the bounds of the
array of piece images as pointers to images. Which Cairo did not like at
all.

This seems to tie up the last loose end. The bugs reported on Savannah
that I could confirm are also all fixed, as are the recently reported ones
on the bug-xboard list.