[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [CASHeW-s-editor-patches] I am commiting changes tosupportconsistent

From: Ravish Bhagdev
Subject: Re: [CASHeW-s-editor-patches] I am commiting changes tosupportconsistent behavour (starting from max always) of editor.......
Date: Sun, 3 Apr 2005 15:26:16 +0100

I believe the 4th point is solved now, still need to change the parser to use factory though. I did not use factory before thinking we are saving the correct model everytime so we don't need checks while recreating . But its wrong anyway as explained by Barry.

In the recent commit, the first point mentioned below is not satisfied. Reason being NodeRegistrar is static and we need to recompute the maximum number everytime the diagram changes ( user selects anyone of the open diagrams )

The commit, uses diagram objects passed into the registry as Andrew explained in the last mail.

Still needs work....and am on it.

- Ravish.

----- Original Message ----- From: "Barry Norton" <address@hidden>
To: "'CASHeW-s Editor Patches'" <address@hidden>
Sent: Thursday, March 31, 2005 2:09 PM
Subject: RE: [CASHeW-s-editor-patches] I am commiting changes tosupportconsistent behavour (starting from max always) of editor.......

OK, now I'm more than a little annoyed - I didn't explain why I wanted
the behaviour I did, nor why I wanted the code in the place I did,
because I thought it would be enough that I had stated it as a

If I have to be completely explicit to have something done the way I
want then here goes:

1) I want the behaviour of auto-naming being based on a simple counter
and increment (rather than a search for the lowest unused name) because
this is part of interactive editing and so must be as quick as possible.

2) I want the behaviour after re-loading a file to be the same (i.e.
next highest name than maximal in diagram, rather than going back and
'filling in the blanks'), because a different behaviour after saving and
reloading the file breaks the user expectation - i.e. consistency is
important, speed is less so on loading a file (this is based on blocking
IO on a disk read, so the additional time working out the largest
'unnamed' name is negligible)

3) I want the functionality that achieves all this in the factory
because otherwise it is going to be massively duplicated (a common
method in the future abstract ProcessFactory superclass should take care
of this, not several separate functions in the parsing functionality).

4) I don't want a static list of node names because (as I've now shown,
despite repeated claims that this wasn't possible) it is possible to
have two diagrams open for editing in the same Eclipse instantiation and
this prevents having two nodes/processes with the same name *in the
different diagrams*!

In future if you're not sure whether something I've gone into details on
is a requirement or just a suggestion, please ask before assuming the

Thanks to Ravish for implementing the functionality, once I explained
the first two of these points, but if re-factoring is necessary to do it
the way I said, please get that done immediately.

And please sort out that final point before I see the editor again...


-----Original Message-----
address@hidden On Behalf Of Andrew John
Sent: Thursday, March 31, 2005 1:19 PM
To: CASHeW-s Editor Patches
Subject: Re: [CASHeW-s-editor-patches] I am commiting changes to
supportconsistent behavour (starting from max always) of editor.......

On Thu, 2005-03-31 at 03:43 +0100, Ravish Bhagdev wrote:
> I am comming the attached patch to allow only nodes with maximum
from the nodes always, as Barry suggested in last meeting.  Three
files are modified as mentioned below (patch attached):
> Changelog:
> 2005-03-31  Ravish Bhagdev  address@hidden
> * src/nongnu/cashews/eclipse/model/
> * src/nongnu/cashews/eclipse/model/
> * src/nongnu/cashews/eclipse/model/
> - getSource() method added in Connection class
> - Parser modified to remove a bug causing repetition of outgoing
in model.
> - Added private int max property in NodeRegistrar along with getter
setter methods for the same.
> - Ravish.
> _______________________________________________
> CASHeW-s-editor-patches mailing list
> address@hidden
> _______________________________________________
> CASHeW-s-editor-patches mailing list
> address@hidden
> _______________________________________________
> CASHeW-s-editor-patches mailing list
> address@hidden

I don't get why you create the Nodes manually in the Parser, rather
using the factory, which already has a method for capturing the node
number.  It seems we have duplicate functionality here.

Also, I don't know what went wrong with the patch, but it seems to
replace the entire parser, even though not all of it has changed.
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)

No software patents in Europe --

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
public class gcj extends Freedom implements Java { ... }

CASHeW-s-editor-patches mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]