[Ccrtp-devel] Bug in Receiver Reports(?) in ccRTP

[Yaniv Levy]

Hello 

It seems that Receiver Reports coming out of ccRTP carry report block sender SSRC in host order instead of host order.

in control.cpp:

uint8
QueueRTCPManager::packReportBlocks(RRBlock* blocks, uint16 &len, 
                   uint16& available)
{
    uint8 j = 0;
    // pack as many report blocks as we can
    SyncSourceLink* i = getFirst();
    for ( ;
          ( ( i != NULL ) && 
        ( len < (available - sizeof(RTCPCompoundHandler::RRBlock)) ) &&
        ( j < 31 ) );
          i = i->getNext() ) {
        SyncSourceLink& srcLink = *i;
        // update stats.
        srcLink.computeStats();
        blocks[j].ssrc = srcLink.getSource()->getID();

i think that the last line should be 
blocks[j].ssrc = htonl(srcLink.getSource()->getID());

Best regards,
Yaniv Levy