Re: [certi-dev] ResignFederationExecution

[Eric Noulard]

2010/11/12 Michael Raab <address@hidden>:
> Hi Eric,

Hi Michael,

> seems to me that in ResignFederationExecution Service the ResignAction
> argument is ignored.

Yes this is the case.
It ignored (not used) inside

FederationManagement.cc:
void FederationManagement::resignFederationExecution(ResignAction,
TypeException &e)

> Therefore I can receive no RemoveObjectInstance callback when a federation 
> leaves. :-(
> Is that correct?

I think it is.

> Is there a chance to fix that short term?

By me in the short term, no sorry :-(
I will be lacking time for that now.

However, as usual I may find time to review a patch.

One or two things you must know about this service is that concerned
RTIA Message is called "M_Remove_Object_Instance"
whereas
RTIG aka NetworkMessage is called  "NM_Remove_Object"

May be the easiest path for solving this would be to add
ObjectManagement::deleteObject calls
in RTIA_federate.cc when
handling Message::RESIGN_FEDERATION_EXECUTION
before the call to
fm->resignFederationExecution(RFEq->getResignAction(), e);

I think fm (FederationManagement) is not concerned by the Action (and
it is not currently uisng it)
but om (ObjectManagement) is.

You may even add a ObjectManagement::deleteAllMyObject()
method and call it.
This would handlde the "DELETE_OBJECTS" case.

enum ResignAction {
    RELEASE_ATTRIBUTES = 1,
    DELETE_OBJECTS,
    DELETE_OBJECTS_AND_RELEASE_ATTRIBUTES,
    NO_ACTION
};

concerning Ownership (for RELEASE_ATTRIBUTES part) I'm not even
sure the it's working now because I'm not aware of any user using
ownership until now?

Do you use Ownership management?
If you only care about deleting object instance then it should doable
relatively fast.
If you care about Ownership too that may take longer...


-- 
Erk
Membre de l'April - « promouvoir et défendre le logiciel libre » -
http://www.april.org