chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Add non-destructive version of alist-updat


From: Felix
Subject: Re: [Chicken-hackers] [PATCH] Add non-destructive version of alist-update!
Date: Thu, 08 Sep 2011 08:11:13 -0400 (EDT)

From: Moritz Heidkamp <address@hidden>
Subject: [Chicken-hackers] [PATCH] Add non-destructive version of alist-update!
Date: Wed, 07 Sep 2011 17:01:56 +0200

> Hi all,
> 
> I'd like to continue with Christian's initiative. Find attached a simple
> patch that adds a non-destructive version of alist-update! named
> (obviously) alist-update to the data-structures unit. It also updates
> the manual accordingly and adds a few test cases for both alist-update!
> and alist-update. Since the patch is so trivial I won't discuss it in
> detail, just take a look and you'll get the idea :-)

Thanks, Moritz. Here a few suggestions:

- alist-update copies more of the argument list than necessary, it 
  only has to copy up to the first matching entry
- an entry for types.db is missing


cheers,
felix



reply via email to

[Prev in Thread] Current Thread [Next in Thread]