chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [patch] error out when installing nonexistant egg


From: Felix
Subject: Re: [Chicken-hackers] [patch] error out when installing nonexistant egg
Date: Fri, 23 Sep 2011 08:37:47 +0200 (CEST)

From: Christian Kellermann <address@hidden>
Subject: [Chicken-hackers] [patch] error out when installing nonexistant egg
Date: Thu, 22 Sep 2011 23:47:41 +0200

> Hi,
> 
> attached is a small patch for issue 683. With it chicken-install
> errors out on non existant extensions and returns an error code of
> 1.
> 
> I am not so sure whether this is the best solution, since
> retrieve-extension should return #f if there is no such file, but
> I guess this is due to a change in henrietta, which does not signal
> an error but returns 200 OK with no chunks.
> 
> So maybe this is the best solution for now. Bails out if there is
> no directory or the retrieved egg directory is empty.

Looks good! I would suggest to use "directory" instead of "find-files",
though (since you don't need the full tree, just whether there is
something or not).


cheers,
felix



reply via email to

[Prev in Thread] Current Thread [Next in Thread]