chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] replace write-line calls to display with i


From: Christian Kellermann
Subject: Re: [Chicken-hackers] [PATCH] replace write-line calls to display with internal procedures.
Date: Mon, 26 Sep 2011 09:25:28 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

* felix winkelmann <address@hidden> [110926 08:45]:
> From: Christian Kellermann <address@hidden>
> Subject: [Chicken-hackers] [PATCH] replace write-line calls to display with 
> internal procedures.
> Date: Sun, 25 Sep 2011 19:45:23 +0200
> 
> > The attached patch should be a little bit faster than the old version
> > since we don't do redundant type checks and call the ports write-string
> > method directly. Thanks to felix for the suggestion.
> 
> Thanks for taking care of this issue, Christian!
> 
> Two more suggestions:
> 
> - use "##sys#check-port*" to make sure the port is open
> - use "##sys#check-port-mode" to do the direction check

Ah, those are convenient. I have attached an updated version of the patch.

Thanks!

Christian

-- 
Who can (make) the muddy water (clear)? Let it be still, and it will
gradually become clear. Who can secure the condition of rest? Let
movement go on, and the condition of rest will gradually arise.
 -- Lao Tse. 

Attachment: write-line-2.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]