Re: [Chicken-hackers] [PATCH] simplify typevar instantiation handling in scrutinizer

[Christian Kellermann]

* felix winkelmann <address@hidden> [110926 13:28]:
> From: Felix <address@hidden>
> Subject: [PATCH] simplify typevar instantiation handling in scrutinizer
> Date: Mon, 26 Sep 2011 09:23:02 +0200 (CEST)
> 
> > Attached is a patch that simplifies the use of
> > "over-all-instantiations" in the scrutinizer. Peter was of course
> > right about the redundant matching at some call-sites of this
> > procedure, which I boneheadedly refused to see.
> > 
> > This patch also fixes a bug in the transformation of the internal
> > node tree to s-expressions for the "##core#typecase" construct.
> > 
> > Testcases have been added. The changes have been tested with the
> > core test-suite and all core libraries and tools.
> 
> Please ignore the previous patch. This new one contains an additional
> fix in "type<=?" (subtype checking).

I cannot say I understand fully what you are doing here. But I could
not find an obvious blunder in it. But then I would have said the
same about the previous version I guess :)

It did not break anything on my system so far, so I say: OK.

Kind regards,

Christian

P.S.: Hopefully I will understand this stuff better soon or this
will blow up in my face sooner or later.

-- 
Who can (make) the muddy water (clear)? Let it be still, and it will
gradually become clear. Who can secure the condition of rest? Let
movement go on, and the condition of rest will gradually arise.
 -- Lao Tse.