chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] proposed bugfix for #706


From: Alan Post
Subject: Re: [Chicken-hackers] [PATCH] proposed bugfix for #706
Date: Wed, 28 Sep 2011 14:49:17 -0600

On Wed, Sep 28, 2011 at 10:10:14PM +0200, Christian Kellermann wrote:
> * Alan Post <address@hidden> [110928 19:32]:
> > I can't see buffer2 being deallocated.  Is there a free() missing
> > here?
> 
> Thanks Alan, I have missed this indeed. As this is only for the
> situations where the name of the file exceeds our famous buffer,
> this would just have sometimes leaked memory, hence we also only
> free it if buffer2 differs from buffer after that part. Does this
> make sense?
> 
> Also can someone confirm that access is part of the POSIX standard
> that windows supports? Mr. Cowan maybe?
> 
> Please find the updated patch attached.
> 
> Thank you!
> 
> Christian
> 

I now notice that barf says "stat" on an OOM error.  Excuse my
nitpicking, but should that be "access"?

-Alan
-- 
.i ma'a lo bradi cu penmi gi'e du



reply via email to

[Prev in Thread] Current Thread [Next in Thread]