Re: [Chicken-hackers] [PATCH] use consistent naming for allocating unsafe SRFI-4 accessors

[Felix]

> On Tue, Feb 21, 2012 at 11:25:30AM +0100, Felix wrote:
>> The attached patch changes some internal SRFI-4 accessors to use the
>> correct naming scheme ("C_a_u_i_..." for allocating, unsafe inline 
>> functions). Also, a bug in the length-check for "f64vector-ref" is
>> fixed.
> 
> Shouldn't this be a CR, or at least keep around the old names for
> one release, in deprecated state?

No, this does not belong to the official C API. 

> 
> I don't know how "official" the C api is, but possibly people are
> relying on these macros.

Then let them suffer.

> 
> By the way, speaking of deprecations, now that we have deprecation
> warnings from the scrutinizer, we should probably also add them for
> C functions and perhaps types as well.

I don't like this much. Too much effort for something non-productive.
I actually changed the deprecation warnings in the scrutinizer to
"notices" (so they are only shown with in verbose mode) - thinking
about your suggestion to make deprecation more verbose made me come to
the conclusion that it must be quite annoying for someone who perhaps
doesn't care (because he does not intend to update, for example).

This reminds me painfully of the linker warnings OpenBSD produces for
the use of "sprintf", one of the most annoying things ever, and one
reason not to use OpenBSD.

> By the way, is MSVC still supported at all?  I saw some reference to
> it near the top of chicken.h (line 117):
> 
> #ifndef _MSC_VAR
> # include <strings.h>
> #endif

I removed this. MSVC is not supported.


cheers,
felix