chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] fix special cases for vector/list-ref in s


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] fix special cases for vector/list-ref in scrutinizer when argument count is wrong
Date: Sun, 4 Mar 2012 17:53:18 +0100
User-agent: Mutt/1.4.2.3i

On Tue, Feb 21, 2012 at 06:53:17PM +0100, Peter Bex wrote:
> Wouldn't the use of and-let* simplify this code?  It could certainly
> remove some nesting.  If you want I can try to come up with a
> replacement patch.

OK, I was lazy in not adding a patch to go with the suggestion.
Here it is after all.  I've also added a patch to treat
##sys#make-structure in the same way.

The final let in list-tail's special casing is strictly
unneccessary but it's there to get the scrutinizer to shut
up about list-tail always returning a true value :)

Cheers,
Peter
-- 
http://sjamaan.ath.cx
--
"The process of preparing programs for a digital computer
 is especially attractive, not only because it can be economically
 and scientifically rewarding, but also because it can be an aesthetic
 experience much like composing poetry or music."
                                                        -- Donald Knuth

Attachment: 0001-fixed-bug-in-handling-of-scrutinizer-special-cases-f.patch
Description: Text document

Attachment: 0002-Also-convert-sys-make-structure-to-use-and-let-like-.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]