chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] pending patches


From: Christian Kellermann
Subject: Re: [Chicken-hackers] pending patches
Date: Fri, 16 Mar 2012 09:56:16 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

* felix winkelmann <address@hidden> [120316 08:34]:
> From: Christian Kellermann <address@hidden>
> Subject: Re: [Chicken-hackers] pending patches
> Date: Mon, 12 Mar 2012 16:04:29 +0100
> 
> > * felix winkelmann <address@hidden> [120312 12:53]:
> >> > - [PATCH] Raise error on construction of too large vectors/blobs
> >> >    (this is a long thread with multiple patches)
> >> 
> >> I have to review this, since it seems to duplicate ##sys#check-range.
> > 
> > Oh, that has been your concern? I have completely misinterpreted
> > your mail then...  It can still work fine without introducing the
> > replication. I can rework this if needed. The error message would
> > be a bit less clear then but the core leaner, which I like (better
> > error messages are second in the like list)...
> 
> If you could change the patch to use ##sys#check-range, I'd be
> grateful.

I have changed the patch to do that. I have also removed the check
for negative values in make-vector as check-range will do that for
us too.

The procedures in srfi-4 use its own version of check-range as this
will be inlined. (This has already existed, and I am reusing this).

The latest version is attached here.

Thanks!

Christian

-- 
9 out of 10 voices in my head say, that I am crazy,
one is humming.

Attachment: 0001-Raise-error-on-construction-of-too-large-vectors-blo.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]