[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] When referencing libchicken, take PROGRAM_
Mario Domenech Goulart
Re: [Chicken-hackers] [PATCH] When referencing libchicken, take PROGRAM_PREFIX into account
Thu, 17 May 2012 10:46:10 -0400
Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux)
On Thu, 17 May 2012 08:27:47 -0400 Mario Domenech Goulart <address@hidden>
> Thanks for looking at that, Peter. Some comments below.
> On Thu, 17 May 2012 13:41:19 +0200 Peter Bex <address@hidden> wrote:
>> On Wed, May 16, 2012 at 02:12:30PM -0400, Mario Domenech Goulart wrote:
>>> Currently, the build system names libchicken taking PROGRAM_PREFIX into
>>> account, but the chicken tools don't. `libchicken' is hardcoded in
>>> chicken tools and tests. That was causing some problems on the
>>> cross-compiling environment I use at work.
>>> The attached patch makes tools load libchicken according to the name
>>> generated by the build system.
>> I applied your patch, but it doesn't take into account PROGRAM_SUFFIX.
>> Also, turns out there are some problems when building a non-cross
>> compiler with prefix/suffix (not caused by your patch).
> Indeed. I overlooked PROGRAM_SUFFIX. I'll try to provide a patch which
> also takes PROGRAM_SUFFIX into account.
It is attached. As Peter suggested on IRC, I used INSTALL_LIB_NAME
instead of passing PROGRAM_PREFIX and PROGRAM_SUFFIX around and
concatenating them (that's INSTALL_LIB_NAME in the end).
By using INSTALL_LIB_NAME, both PROGRAM_PREFIX and PROGRAM_SUFFIX are
Description: Text Data