chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Check all elements of the list for being a


From: Mario Domenech Goulart
Subject: Re: [Chicken-hackers] [PATCH] Check all elements of the list for being a string in make-pathname
Date: Thu, 24 May 2012 13:33:40 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux)

Hi Christian,

On Thu, 24 May 2012 19:15:58 +0200 Christian Kellermann <address@hidden> wrote:

> The diff below fixes the bug methinks.

Thanks for looking into it.

Wouldn't

diff --git a/files.scm b/files.scm
index 3fae8f5..5c00875 100644
--- a/files.scm
+++ b/files.scm
@@ -178,6 +178,7 @@ EOF
       (if (null? strs)
          ""
          (let ((s1 (car strs)))
+           (##sys#check-string s1 'make-pathname)
            (if (zero? (string-length s1))
                (loop (cdr strs))
                (string-append 

be better, since it doesn't traverse the list twice?


Best wishes.
Mario
-- 
http://parenteses.org/mario



reply via email to

[Prev in Thread] Current Thread [Next in Thread]