[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Check all elements of the list for being a
Mario Domenech Goulart
Re: [Chicken-hackers] [PATCH] Check all elements of the list for being a string in make-pathname
Thu, 24 May 2012 16:00:19 -0400
Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux)
On Thu, 24 May 2012 13:59:07 -0400 Mario Domenech Goulart <address@hidden>
> On Thu, 24 May 2012 19:43:02 +0200 Christian Kellermann <address@hidden>
>> * Mario Domenech Goulart <address@hidden> [120524 19:37]:
>>> On Thu, 24 May 2012 19:15:58 +0200 Christian Kellermann <address@hidden>
>>> > The diff below fixes the bug methinks.
>>> Thanks for looking into it.
>>> Wouldn't be better, since it doesn't traverse the list twice?
>> Hm, yeah. I wanted to separate the argument checking from the
>> processing of the string, but either is fine with me!
>> Attached is the patch in the version you suggested.
>> Thanks Mario!
> Thanks, Christian. I've pushed your patch and closed #855.
Hmmm. I wonder if that is the right fix for the problem. It seems that
it has been introduced between 4.7.3 and 4.7.4. In that period, the was
no relevant change to files.scm.
I'm going to keep that commit as a workaround, but I'm going to reopen
#855 just in case. Maybe we are just covering a more serious compiler