[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] copy directories recursively when given to
Re: [Chicken-hackers] [PATCH] copy directories recursively when given to "install-extension"
Sat, 9 Jun 2012 13:53:42 +0200
On Thu, Jun 07, 2012 at 04:07:55PM +0200, Felix wrote:
> The attached patch is an attempt to fix the problem recently reported
> about the broken installation of the "spock" egg. This egg wants to
> install a local directory with library code in the repository, but the
> command to copy the directory and all contained files is currently
> broken, due to incompatibilities between UNIX' and Windows' way of
> copying files.
> The patch modifies "install-extension" to detect directories and copy
> contained files individually, taking care of creating subdirectories
> as needed. This seems to work fine on Linux and Windows, at least for
> the simple tests I did.
Why is ensure-directory changed? The new optional argument isn't being
passed anywhere I can see, so the change seems to be either unneccessary
or there's a mistake in one of the calls (looks like the former, to me).
"The process of preparing programs for a digital computer
is especially attractive, not only because it can be economically
and scientifically rewarding, but also because it can be an aesthetic
experience much like composing poetry or music."
-- Donald Knuth