[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] catch exceptions in finalizers, remove dyn

From: Jim Ursetto
Subject: Re: [Chicken-hackers] [PATCH] catch exceptions in finalizers, remove dynamic resizing of finalizer vector
Date: Tue, 19 Jun 2012 13:14:25 -0500

Hi Felix,

On Jun 19, 2012, at 1:03 PM, Felix wrote:

> From: Jim Ursetto <address@hidden>
>> Might I suggest that these nice thorough explanations be put in the
>> patch message itself (preceded by a blank line), so we always
>> have them at hand.
> Sure. Do you want one blank line or two? I can add some ASCII-art, too,
> if you like that sort of thing.

The blank line is a git convention so that it separates the summary
from the long description in git log --oneline.  You can add an
extra blank line if you feel particularly saucy that day.
ASCII-art would be acceptable too, I miss the old banners.

> On the other hand: feel free to sign off
> the patch and have a go yourself.

I thought it was ok to comment on patches without signing off.
I would have signed off if I felt qualified to review it.

> But yes, I will keep this in mind for the patch after the next.

Cool, thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]